Expose ui point radii to logging & blueprint, remove old default radius settings in favor of blueprint default components #6678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔺 re_renderer
Deployed docs
|
An error occurred while trying to automatically change base from
andreas/only-apply-change-on-input
to
main
June 28, 2024 16:45
Wumpf
force-pushed
the
andreas/expose-negative-radii
branch
from
13b69c6 to
21aa36f
Compare
Wumpf
force-pushed
the
andreas/expose-negative-radii
branch
from
283865f to
776a153
Compare
emilk
reviewed
Jul 1, 2024
emilk
approved these changes
Jul 1, 2024
| // When we change the type of units,the value is likely going to be _very wrong_. | ||
| // Unfortunately, we don't have knowledge of a fallback here, so we to hardcoded "reasonable" values. | ||
| if is_scene_units { | ||
| abs_value = 0.5; |
There was a problem hiding this comment.
It would be nice to be able to use the auto_size_world_heuristic somehow, but I guess that's a hard ask
There was a problem hiding this comment.
yeah 100% and it would indeed be a very complicated/annoying wire to put in. That's what I meant above with not being able to access a fallback (fallbacks have this kind of context sensitive information)
|
Fixed -0/+0 distinction! |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9746942257 |
|
|
emilk
reviewed
Jul 2, 2024
emilk
approved these changes
Jul 2, 2024
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9757099329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screen.Recording.2024-06-28.174328.mp4
Also cleans up all the way down to re_renderer, removing the special auto size values we used to check for at rendering time.
Adds 4 new code snippets: ui vs scene radius for point2d/point3d/line2d/line3d. It can be used with even more components but this should be enough to make it discoverable
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.